Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates #192

Merged
merged 4 commits into from
Aug 23, 2024
Merged

Updates #192

merged 4 commits into from
Aug 23, 2024

Conversation

K20shores
Copy link
Collaborator

Correctly setting reaction rates using both name and type

Comment on lines +182 to +188
reaction_exists = False
for rate in reaction_rates:
if rate.reaction.name == reaction.name:
reaction_exists = True
break

if not reaction_exists:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't actually know what this does but it's apparently crucial and tests fail without it

@K20shores K20shores merged commit 404e6f1 into main Aug 23, 2024
4 checks passed
@K20shores K20shores deleted the updates branch August 23, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants